diff options
| author | Michael Catanzaro <mcatanzaro@redhat.com> | 2021-07-12 08:38:02 -0500 |
|---|---|---|
| committer | Patrick <tingping@tingping.se> | 2021-07-12 11:29:15 -0500 |
| commit | 25440a07c3b421134b4376d7db3ee4b7ed57ad98 (patch) | |
| tree | 73f110696622d7246bf3d64c4ab82f8f67bffe26 /src/fe-gtk | |
| parent | 869a8d7ab335cf785e06450e4ab1ca02a9f5005f (diff) | |
Avoid direct use of libproxy
Since hexchat already depends on GLib, it's better to use GProxyResolver instead. This might use libproxy, or not, as appropriate. P.S. This removes a memory safety issue because proxy_list is allocated using malloc(), not g_malloc(), and therefore using g_strfreev() is incorrect. The proper way to free the proxy list returned by libproxy is to use px_proxy_factory_free_proxies() (but nobody does that because it was added in libproxy 0.4.16, which is somewhat recent).
Diffstat (limited to 'src/fe-gtk')
| -rw-r--r-- | src/fe-gtk/setup.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/fe-gtk/setup.c b/src/fe-gtk/setup.c index 3d003eef..a7e3a15c 100644 --- a/src/fe-gtk/setup.c +++ b/src/fe-gtk/setup.c @@ -614,9 +614,7 @@ static const char *const proxytypes[] = N_("SOCKS4"), N_("SOCKS5"), N_("HTTP"), -#ifdef USE_LIBPROXY N_("Auto"), -#endif NULL }; |