summary refs log tree commit diff stats
path: root/src/common
AgeCommit message (Collapse)Author
2018-10-13Fix UB (dangling pointer usage) fix-ubSoniEx2
Using dangling pointers, even if it's just to compare them with valid pointers (such as comparing them with the ones in sess_list), is UB. This fixes that.
2018-09-01Fix new stringop-truncation warningsPatrick Griffis
2018-08-16Fix inconsistent behavior (re)connecting on SSLIvan
2018-05-08Fix sending PASS with spaces or starting with :jkhsjdhjs
Closes #2186 Closes #1550
2018-04-03Validate all translations contain valid text eventsPatrick Griffis
2018-03-31Fix plugins on macOSRainer Müller
The switch to the meson build system broke plugins on macOS. GNU libtool builds shared libraries with ".dylib" and shared modules (plugins) with the extension ".so", but meson is using ".dylib" for both. Although overriding the name_suffix for shared_module() in meson is possible, this would be messy for other platforms as there is no way to query the default. Therefore it seems like we have to go with ".dylib" for now on macOS. However, G_MODULE_SUFFIX is defined to ".so", because glib follows what GNU libtool does. Therefore define a separate preprocessor macro that has the correct extension. See: https://github.com/mesonbuild/meson/issues/1160
2018-03-11Fix fscanf() usage without size limitPatrick Griffis
Closes #2137
2018-03-09Fix /ignore not accepting full hostsPatrick Griffis
Fixes #1828
2018-03-09Remove mpcinfo pluginPatrick Griffis
The code quality of it is terrible, the user experience of using it is terrible, and it should have been removed years ago
2018-03-09win32: Update to build against gvsbuildPatrick Griffis
2018-03-09Various fixes for mingwPatrick Griffis
2018-03-04Fix out of bounds read when DCC message sender contains quotesPatrick Griffis
This cannot be triggered by any user generally. Fixes #2128
2018-03-02Fix possible out of bounds read when being ctcp floodedPatrick Griffis
Note that this is unlikely to be triggerable by another user. Thanks to @dequis for discovering.
2018-02-18dbus: Add option to use app-id for bus namePatrick Griffis
This is required for Flatpak but is an API break so it is opt-in for now.
2017-10-25Fix crash when connect commands change networkPatrick Griffis
Fixes #2084
2017-10-16Fix oob read in ctcp_checkJoseph Bisch
word[4] can be too short, leading to the addition of ctcp_offset putting us out of bounds. This results in an oob read in ctcp_check.
2017-10-16A tiny code style changeDren Kajmakchi
2017-10-11servlist: Add BuddyIM network (#2072)Ken Spencer
2017-10-10Add an option to disable rejoin on auto reconnectIwan Aucamp
This change adds an option `irc_reconnect_rejoin` (default ON) which when turned OFF will prevent hexchat from rejoining channels after an auto reconnect. hexchat/hexchat#2069
2017-10-07Improve CTCP notice handlingPatrick Griffis
Cutting off all text after \001 can result in users hiding text so lets only bother handling it if it is a valid CTCP message (starting and ending with \001).
2017-10-02Use g_utf8_make_valid if available for cleaner utf8 handling (#2065)Joseph Bisch
2017-09-21Fix rfc_ncasecmp handling of n reaching 0Joseph Bisch
If n becomes 0 at the same time that the end of either s1 or s2 are reached, the next iteration of the while loop wouldn't happen, so we wouldn't correctly return 0.
2017-09-19Handle leading spaces when matching extra alertsPatrick Griffis
It is common for users to set "foo, bar" and the leading space has caused issues in the past so lets just ignore that.
2017-09-19Fix rfc_{n,}casecmp functions (#2058)Joseph Bisch
rfc_casecmp was broken because reaching terminator for str1 was used as a terminal condition and str2 may be shorter than str1, resulting in an oob read condition for str2. rfc_ncasecmp was broken because it checked if n characters were checked or if BOTH pointers reached their terminator, however the strings may be different lengths and also less than n characters in length, meaning that they don't both reach their terminators at the same time, resulting in an oob read condition.
2017-09-18Fix oob read caused by ptr[0] being NULL in inbound_noticeJoseph Bisch
If ptr[0] is NULL, then strchr may return a pointer to the NULL terminator for serv->nick_prefixes, making the if statement true, which then leads to the pointer increment leaving ptr oob. Now we check to ensure ptr[0] != NULL. From the Linux manpages for strchr: The terminating null byte is considered part of the string, so that if c is specified as '\0', these functions return a pointer to the terminator.
2017-08-31Improve detection of system tray supportPatrick Griffis
Closes #2045
2017-08-19UI text consistency, capitalization etc.torhus
2017-08-18Adjust use of ellipsis (...) in menus according to Gnome HIG (#2035)torhus
* Adjust use of ellipses (...) in menus according to Gnome HIG https://developer.gnome.org/hig/stable/writing-style.html.en
2017-07-16servlist: skip empty lines.Mark Jansen
Fixes #1999
2017-07-04Better handle channels with / in them with doat commandPatrick Griffis
/doat #foo/bar/freenode would work for example.
2017-06-26build: Fix building plugins in cygwinPatrick Griffis
2017-06-22Fix skipping autoconnect when passed 1 URLPatrick Griffis
2017-06-18Fix crash on coloring NULL nicksPatrick Griffis
Fixes #2014
2017-06-15Fix OpenSSL 1.1 deprecationsPatrick Griffis
2017-06-13build: Replace Autotools with MesonPatrick Griffis
Quick rundown of benefits: - Much faster: - Autotools (with autogen): 22 seconds - Meson: 7 seconds - Meson (with ccache): 2 seconds - Simpler: - ~1000 lines smaller - Single simple language - Potentially better Windows (Visual Studio) support What is not done: - Complete Windows support - OSX support (easy) Closes #2013 Closes #1937 Closes #1803
2017-06-10Actually respect away_omit_alerts for custom sounds...Patrick Griffis
Probably should think before merging things.
2017-06-10Disable custom sounds when away_omit_alerts enabledYuGiOhJCJ
Closes #2012
2017-03-10Fix email address pattern, it can starts with digitShengyu Zhang
2017-02-18Better handle mode numerics starting with :Patrick Griffis
These are still awful but until we have a real parser.. Fixes inspircd/inspircd#1295
2017-01-07servlist: Use SSL with OFTC by defaultPatrick Griffis
They now use Lets Encrypt which should be trusted.
2017-01-05Increase default scrollback size to 5kPatrick Griffis
This is totally reasonable for a modern computer.
2016-12-13Use AC_CHECK_FUNCS to find functions not in LibreSSLFlorian Stinglmayr
LibreSSL might not have all functions of OpenSSL 1.1.0 so use AC_CHECK_FUNCS to find them first before using them. Closes #1899 Fixes #1898
2016-12-04Enable input_filter_beep by defaultPatrick Griffis
This just allows for spam.
2016-12-04Avoid mixed declarationPatrick Griffis
2016-12-04Fix printing invalid utf8 from /exec outputPatrick Griffis
This could possibly cause a crash. On a related note exec_data() and exec_handle_colors() could probably use a pass cleaning up to ensure they "do the right thing".
2016-12-01properly clean the autogenerated org.hexchat.service.serviceMattia Rizzolo
2016-11-30Fix timers being incorrectly removedPatrick Griffis
Possibly fixing #1866
2016-11-28Fix typos s/Recieved/Received/Mattia Rizzolo
2016-11-11Respect plugin hook changing tab colorPatrick Griffis
Fixup to 241dd69b081
2016-11-11Further tab color improvementsPatrick Griffis
- Combine the three properties into a single one - Finally fully fix the handling with plugins handling events TODO: Look into lastact handling of these, seems wrong
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-12-24 17:35:46 +0000