summary refs log tree commit diff stats
path: root/src/fe-gtk
diff options
context:
space:
mode:
authorTingPing <tingping@tingping.se>2015-02-11 17:58:44 -0500
committerTingPing <tingping@tingping.se>2015-02-11 17:58:44 -0500
commit7063406d6caf42f61d87e42db6ce46df9e64ffef (patch)
tree34807a61e8a80c40fedaad33ee9d89d300fd03be /src/fe-gtk
parent9858784eb6369dc189836f8971791af5238145ea (diff)
Remove input_balloon_time setting
This setting doesn't work on most platforms
including some notification daemons on linux.

Where it does work I think it is bad behavior
to default overriding their defaults anyway.

It's most valuable use was likely win32
tray balloons which no longer exist.
Diffstat (limited to 'src/fe-gtk')
-rw-r--r--src/fe-gtk/notifications/notification-backend.h2
-rw-r--r--src/fe-gtk/notifications/notification-dummy.c2
-rw-r--r--src/fe-gtk/notifications/notification-libnotify.c3
-rw-r--r--src/fe-gtk/notifications/notification-osx.m2
-rw-r--r--src/fe-gtk/notifications/notification-windows.c6
-rw-r--r--src/fe-gtk/notifications/notification-winrt.cpp2
-rw-r--r--src/fe-gtk/plugin-notification.c12
7 files changed, 9 insertions, 20 deletions
diff --git a/src/fe-gtk/notifications/notification-backend.h b/src/fe-gtk/notifications/notification-backend.h
index 98686d73..b60ced4e 100644
--- a/src/fe-gtk/notifications/notification-backend.h
+++ b/src/fe-gtk/notifications/notification-backend.h
@@ -20,7 +20,7 @@
 #define HEXCHAT_PLUGIN_NOTIFICATION_BACKEND_H
 
 int notification_backend_supported (void);
-void notification_backend_show (const char *title, const char *text, int timeout);
+void notification_backend_show (const char *title, const char *text);
 int notification_backend_init (void);
 void notification_backend_deinit (void);
 
diff --git a/src/fe-gtk/notifications/notification-dummy.c b/src/fe-gtk/notifications/notification-dummy.c
index 1b719cfa..022443bf 100644
--- a/src/fe-gtk/notifications/notification-dummy.c
+++ b/src/fe-gtk/notifications/notification-dummy.c
@@ -17,7 +17,7 @@
  */
 
 void
-notification_backend_show (const char *title, const char *text, int timeout)
+notification_backend_show (const char *title, const char *text)
 {
 }
 
diff --git a/src/fe-gtk/notifications/notification-libnotify.c b/src/fe-gtk/notifications/notification-libnotify.c
index d3e3a992..94f9679d 100644
--- a/src/fe-gtk/notifications/notification-libnotify.c
+++ b/src/fe-gtk/notifications/notification-libnotify.c
@@ -23,7 +23,7 @@
 static gboolean strip_markup = FALSE;
 
 void
-notification_backend_show (const char *title, const char *text, int timeout)
+notification_backend_show (const char *title, const char *text)
 {
 	NotifyNotification *notification;
 
@@ -33,7 +33,6 @@ notification_backend_show (const char *title, const char *text, int timeout)
 	notification = notify_notification_new (title, text, "hexchat");
 	notify_notification_set_hint (notification, "desktop-entry", g_variant_new_string ("hexchat"));
 
-	notify_notification_set_timeout (notification, timeout);
 	notify_notification_show (notification, NULL);
 
 	g_object_unref (notification);
diff --git a/src/fe-gtk/notifications/notification-osx.m b/src/fe-gtk/notifications/notification-osx.m
index c97c6629..c9ad72d0 100644
--- a/src/fe-gtk/notifications/notification-osx.m
+++ b/src/fe-gtk/notifications/notification-osx.m
@@ -20,7 +20,7 @@
 #include <gtkosxapplication.h>
 
 void
-notification_backend_show (const char *title, const char *text, int timeout)
+notification_backend_show (const char *title, const char *text)
 {
 	NSString *str_title = [[NSString alloc] initWithUTF8String:title];
 	NSString *str_text = [[NSString alloc] initWithUTF8String:text];
diff --git a/src/fe-gtk/notifications/notification-windows.c b/src/fe-gtk/notifications/notification-windows.c
index 16cf3412..3fade306 100644
--- a/src/fe-gtk/notifications/notification-windows.c
+++ b/src/fe-gtk/notifications/notification-windows.c
@@ -23,20 +23,20 @@
 
 #include <Windows.h>
 
-void (*winrt_notification_backend_show) (const char *title, const char *text, int timeout) = NULL;
+void (*winrt_notification_backend_show) (const char *title, const char *text) = NULL;
 int (*winrt_notification_backend_init) (void) = NULL;
 void (*winrt_notification_backend_deinit) (void) = NULL;
 int (*winrt_notification_backend_supported) (void) = NULL;
 
 void
-notification_backend_show (const char *title, const char *text, int timeout)
+notification_backend_show (const char *title, const char *text)
 {
 	if (winrt_notification_backend_show == NULL)
 	{
 		return;
 	}
 
-	winrt_notification_backend_show (title, text, timeout);
+	winrt_notification_backend_show (title, text);
 }
 
 int
diff --git a/src/fe-gtk/notifications/notification-winrt.cpp b/src/fe-gtk/notifications/notification-winrt.cpp
index 74cc2e78..663f9c08 100644
--- a/src/fe-gtk/notifications/notification-winrt.cpp
+++ b/src/fe-gtk/notifications/notification-winrt.cpp
@@ -41,7 +41,7 @@ widen(const std::string & to_widen)
 extern "C"
 {
 	__declspec (dllexport) void
-	notification_backend_show (const char *title, const char *text, int timeout)
+	notification_backend_show (const char *title, const char *text)
 	{
 		try
 		{
diff --git a/src/fe-gtk/plugin-notification.c b/src/fe-gtk/plugin-notification.c
index 43ceeece..04a64213 100644
--- a/src/fe-gtk/plugin-notification.c
+++ b/src/fe-gtk/plugin-notification.c
@@ -60,16 +60,6 @@ should_alert (void)
 	return TRUE;
 }
 
-/* Returns timeout in ms */
-static int
-get_timeout (void)
-{
-	int timeout = 0;
-	hexchat_get_prefs (ph, "input_balloon_time", NULL, &timeout);
-
-	return timeout * 1000;
-}
-
 static gboolean
 is_ignored (char *nick)
 {
@@ -91,7 +81,7 @@ show_notification (const char *title, const char *text)
 	stripped_title = hexchat_strip (ph, title, -1, 7);
 	stripped_text = hexchat_strip (ph, text, -1, 7);
 	
-	notification_backend_show (stripped_title, stripped_text, get_timeout ());
+	notification_backend_show (stripped_title, stripped_text);
 
 	hexchat_free (ph, stripped_title);
 	hexchat_free (ph, stripped_text);