diff options
| author | XhmikosR <xhmikosr@users.sourceforge.net> | 2013-10-10 00:05:22 -0400 |
|---|---|---|
| committer | TingPing <tingping@tingping.se> | 2013-10-10 00:05:22 -0400 |
| commit | c226f4089ae99283dab4f681710ce798c3908969 (patch) | |
| tree | 8f1b9b8373ca4b1bb09c39194279d524b2c93fda /plugins | |
| parent | e244001cee150d574e668aaf478626a036d31cc9 (diff) | |
Fix a few cppcheck warnings.
Use the proper data type in format functions and fix a resource leak.
Diffstat (limited to 'plugins')
| -rw-r--r-- | plugins/mpcinfo/mp3Info.c | 1 | ||||
| -rw-r--r-- | plugins/mpcinfo/oggInfo.c | 2 | ||||
| -rw-r--r-- | plugins/sysinfo/xsys.c | 8 |
3 files changed, 6 insertions, 5 deletions
diff --git a/plugins/mpcinfo/mp3Info.c b/plugins/mpcinfo/mp3Info.c index b7112a5d..99718624 100644 --- a/plugins/mpcinfo/mp3Info.c +++ b/plugins/mpcinfo/mp3Info.c @@ -244,6 +244,7 @@ struct tagInfo readID3V2(char *file){ for (i=0;i<10;i++){ c=fgetc(f); if (c==EOF){ + fclose(f); //putlog("found eof while reading id3v2"); return ret; } diff --git a/plugins/mpcinfo/oggInfo.c b/plugins/mpcinfo/oggInfo.c index ee7d6363..59d84791 100644 --- a/plugins/mpcinfo/oggInfo.c +++ b/plugins/mpcinfo/oggInfo.c @@ -77,7 +77,7 @@ struct tagInfo getOggHeader(char *file){ info.bitrate=nomBr; if (((maxBr==nomBr)&&(nomBr=minBr))||((minBr==0)&&(maxBr==0))||((minBr=-1)&&(maxBr=-1)) )info.cbr=1;else info.cbr=0; printf("bitrates: %i|%i|%i\n",maxBr,nomBr,minBr); - printf("freq: %i\n",info.freq); + printf("freq: %u\n",info.freq); pos=h3pos+7; pos+=getOggInt(header,pos,4)+4; count=getOggInt(header,pos,4); diff --git a/plugins/sysinfo/xsys.c b/plugins/sysinfo/xsys.c index 21ba6d8f..474729c5 100644 --- a/plugins/sysinfo/xsys.c +++ b/plugins/sysinfo/xsys.c @@ -140,11 +140,11 @@ print_summary (int announce, char* format) if (giga) { - snprintf (buffer, bsize, "%d x %s (%s) @ %.2fGHz", count, cpu_model, cpu_vendor, cpu_freq); + snprintf (buffer, bsize, "%u x %s (%s) @ %.2fGHz", count, cpu_model, cpu_vendor, cpu_freq); } else { - snprintf (buffer, bsize, "%d x %s (%s) @ %.0fMHz", count, cpu_model, cpu_vendor, cpu_freq); + snprintf (buffer, bsize, "%u x %s (%s) @ %.0fMHz", count, cpu_model, cpu_vendor, cpu_freq); } format_output ("CPU", buffer, format); @@ -332,11 +332,11 @@ print_cpu (int announce, char* format) if (giga) { - snprintf (buffer, bsize, "%d x %s (%s) @ %.2fGHz w/ %s L2 Cache", count, model, vendor, freq, cache); + snprintf (buffer, bsize, "%u x %s (%s) @ %.2fGHz w/ %s L2 Cache", count, model, vendor, freq, cache); } else { - snprintf (buffer, bsize, "%d x %s (%s) @ %.0fMHz w/ %s L2 Cache", count, model, vendor, freq, cache); + snprintf (buffer, bsize, "%u x %s (%s) @ %.0fMHz w/ %s L2 Cache", count, model, vendor, freq, cache); } format_output ("CPU", buffer, format); |